Introduce new CSAL ftl bdev #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussion question: The |
MaisenbacherD
force-pushed
the
csal-support
branch
from
b4e6c94 to
6374141
Compare
MaisenbacherD
force-pushed
the
csal-support
branch
from
6374141 to
c88d9a2
Compare
tiagolobocastro
approved these changes
Nov 21, 2024
MaisenbacherD
force-pushed
the
csal-support
branch
from
c88d9a2 to
12e974e
Compare
|
bors try |
tryBuild failed: |
MaisenbacherD
force-pushed
the
csal-support
branch
from
12e974e to
1dac4b4
Compare
|
Addressed the linter errors :) |
|
bors try |
tryBuild failed: |
|
Linter failures still. Could you please run below script in your workspace: Please refer https://gist.github.com/dsharma-dc/a14488638a7815561571882759e7921e |
MaisenbacherD
force-pushed
the
csal-support
branch
from
1dac4b4 to
d8a4b8c
Compare
Thanks for the hint :) I just ran the script. |
|
bors try |
MaisenbacherD
force-pushed
the
csal-support
branch
from
d8a4b8c to
2668c1a
Compare
|
I updated the spdk-rs submodule reference to the merged commit from openebs/spdk-rs#69 :) |
tryBuild failed: |
|
bors try |
|
🔒 Permission denied Existing reviewers: click here to make MaisenbacherD a reviewer |
|
You should be able to use bors with this: |
|
✌️ MaisenbacherD can now approve this pull request. To approve and merge a pull request, simply reply with |
MaisenbacherD
force-pushed
the
csal-support
branch
from
2668c1a to
5b1f0d9
Compare
|
Resolved some more linter issues :) |
|
bors d+ |
|
✌️ MaisenbacherD can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors try |
dsharma-dc
reviewed
Nov 26, 2024
tryTimed out. |
MaisenbacherD
force-pushed
the
csal-support
branch
from
5b1f0d9 to
4abf200
Compare
|
Updated spdk-rs submodule reference openebs/spdk-rs#70 (review) |
The SPDK ftl bdev allows to create a layered device with a (fast) cache device for buffering writes that get eventually flushed out sequentially to a base device. SDPK ftl is also known as the Cloud Storage Acceleration Layer (CSAL). This kind of device potentially enables the use of emerging storage interfaces like Zoned Namespace (ZNS) or Flexible Data Placement (FDP) capable NVMe devices. Up to this point, those NVMe command sets are not yet supported in SPDK upstream. However, the acceleration aspect of a fast cache device already adds value. With future support of new devices for SDPK ftl, Mayastor would already be capable of utilizing those features simply by upgrading SDPK. For now, the `ftl_mount_fs` test cases are hidden behind the `nvme-pci-tests` flag because PCIe devices are required for this test until SPDK v24.09 is picked up, which introduces variable sector size emulation for ftl devices. To run these tests use the following: ``` RUST_LOG=TRACE cargo test --features nvme-pci-tests -- --test-threads 1 \ --test ftl_mount_fs --nocapture ``` This patch introduces a new ftl device uri scheme: ``` ftl:///$ftl_device_name?bbdev=$bbdev_uri_percent_encoded&cbdev=$cbdev_uri_percent_encoded ``` The bbdev_uri and cbdev_uri need to use percent encoding on '?' (= '%3F') and '&' (= '%26') segment dividers. This is needed so we can successfully parse the ftl uri. Optionally, the sub-uris may also be fully percent-encoded. With SPDK v24.05 only PCIe devices will work where the cache device is formatted to 4KiB+64B LBA format and the base device to 4KiB LBA format. From SPDK v24.09 on, any device with a block size of 4KiB will work for both cache and base device. CSAL paper reference: https://dl.acm.org/doi/10.1145/3627703.3629566 Co-authored-by: Indraneel M <[email protected]> Signed-off-by: Dennis Maisenbacher <[email protected]>
Signed-off-by: Dennis Maisenbacher <[email protected]>
Init SPDK tracing when `MayastorEnvironment.num_enties` is set to a positive integer. This can be helpfull when developing new features. Traces can be found in `/dev/shm` and have the pid or if not negative the `MayastorEnvironment.shm_id` as a suffix. Further information about traces and how to read the captured traces can be found here: https://spdk.io/doc/nvmf_tgt_tracepoints.html Signed-off-by: Dennis Maisenbacher <[email protected]>
MaisenbacherD
force-pushed
the
csal-support
branch
from
4abf200 to
a16f45c
Compare
|
@dsharma-dc Thanks for your comments :) |
|
bors try |
dsharma-dc
approved these changes
Nov 28, 2024
tryBuild succeeded: |
|
bors merge |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
1771: Introduce new CSAL ftl bdev r=tiagolobocastro a=MaisenbacherD For this PR to be merged the PR openebs/spdk-rs#67 for spdk-rs needs to be resolved and the submodule reference must be updated accordingly. :) The SPDK ftl bdev allows to create a layered device with a (fast) cache device for buffering writes that get eventually flushed out sequentially to a base device. SDPK ftl is also known as the Cloud Storage Acceleration Layer (CSAL). This kind of device potentially enables the use of emerging storage interfaces like Zoned Namespace (ZNS) or Flexible Data Placement (FDP) capable NVMe devices. Up to this point, those NVMe command sets are not yet supported in SPDK upstream. However, the acceleration aspect of a fast cache device already adds value. With future support of new devices for SDPK ftl, Mayastor would already be capable of utilizing those features simply by upgrading SDPK. For now, the `ftl_mount_fs` test cases are hidden behind the `ignore` attribute because PCIe devices are required for this test until SPDK v24.09 is picked up, which introduces variable sector size emulation for ftl devices. To run these tests use the following: ``` RUST_LOG=TRACE cargo test -- --test-threads 1 --test ftl_mount_fs --nocapture --ignored ``` This patch introduces a new ftl device uri scheme: ``` ftl:///<ftl-device-name>?bbdev=<dev-uri-nested-encoding>&cbdev=<dev-uri-nested-encoding> ``` `<dev-uri-nested-encoding>` can be any already valid device uri where '?' are replaced with '!' and '&' are replaced with '|'. With SPDK v24.05 only PCIe devices will work where the cache device is formatted to 4KiB+64B LBA format and the base device to 4KiB LBA format. From SPDK v24.09 on, any device with a block size of 4KiB will work for both cache and base device. CSAL paper reference: https://dl.acm.org/doi/10.1145/3627703.3629566 Co-authored-by: Dennis Maisenbacher <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried. Additional information: Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"} |
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
1771: Introduce new CSAL ftl bdev r=tiagolobocastro a=MaisenbacherD For this PR to be merged the PR openebs/spdk-rs#67 for spdk-rs needs to be resolved and the submodule reference must be updated accordingly. :) The SPDK ftl bdev allows to create a layered device with a (fast) cache device for buffering writes that get eventually flushed out sequentially to a base device. SDPK ftl is also known as the Cloud Storage Acceleration Layer (CSAL). This kind of device potentially enables the use of emerging storage interfaces like Zoned Namespace (ZNS) or Flexible Data Placement (FDP) capable NVMe devices. Up to this point, those NVMe command sets are not yet supported in SPDK upstream. However, the acceleration aspect of a fast cache device already adds value. With future support of new devices for SDPK ftl, Mayastor would already be capable of utilizing those features simply by upgrading SDPK. For now, the `ftl_mount_fs` test cases are hidden behind the `ignore` attribute because PCIe devices are required for this test until SPDK v24.09 is picked up, which introduces variable sector size emulation for ftl devices. To run these tests use the following: ``` RUST_LOG=TRACE cargo test -- --test-threads 1 --test ftl_mount_fs --nocapture --ignored ``` This patch introduces a new ftl device uri scheme: ``` ftl:///<ftl-device-name>?bbdev=<dev-uri-nested-encoding>&cbdev=<dev-uri-nested-encoding> ``` `<dev-uri-nested-encoding>` can be any already valid device uri where '?' are replaced with '!' and '&' are replaced with '|'. With SPDK v24.05 only PCIe devices will work where the cache device is formatted to 4KiB+64B LBA format and the base device to 4KiB LBA format. From SPDK v24.09 on, any device with a block size of 4KiB will work for both cache and base device. CSAL paper reference: https://dl.acm.org/doi/10.1145/3627703.3629566 Co-authored-by: Dennis Maisenbacher <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried. Additional information: Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"} |
|
doh, had missed a couple |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this PR to be merged the PR openebs/spdk-rs#67
for spdk-rs needs to be resolved and the submodule reference must be
updated accordingly. :)
The SPDK ftl bdev allows to create a layered device with a (fast) cache
device for buffering writes that get eventually flushed out sequentially
to a base device. SDPK ftl is also known as the Cloud Storage
Acceleration Layer (CSAL).
This kind of device potentially enables the use of emerging storage
interfaces like Zoned Namespace (ZNS) or Flexible Data Placement (FDP)
capable NVMe devices. Up to this point, those NVMe command sets are not
yet supported in SPDK upstream. However, the acceleration aspect of a
fast cache device already adds value.
With future support of new devices for SDPK ftl, Mayastor would already
be capable of utilizing those features simply by upgrading SDPK.
For now, the
ftl_mount_fstest cases are hidden behind theignoreattribute because PCIe devices are required for this test until
SPDK v24.09 is picked up, which introduces variable sector size emulation
for ftl devices.
To run these tests use the following:
This patch introduces a new ftl device uri scheme:
<dev-uri-nested-encoding>can be any already valid device uri where '?'are replaced with '!' and '&' are replaced with '|'.
With SPDK v24.05 only PCIe devices will work where the cache device is
formatted to 4KiB+64B LBA format and the base device to 4KiB LBA format.
From SPDK v24.09 on, any device with a block size of 4KiB will work for
both cache and base device.
CSAL paper reference:
https://dl.acm.org/doi/10.1145/3627703.3629566