Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug #3785): adresses ssl wrong version error when pointing to rest https end… #5

Open
wants to merge 1 commit into
base: rust_mayastor
Choose a base branch
from

Conversation

Johnaius
Copy link

Issue 3785

This PR address "wrong version number" error when using tls to communicate with api-rest.
 

@@ -336,9 +336,9 @@ impl Configuration {
let client = {
match certificate {
None => {
let mut http = hyper_tls::HttpsConnector::new();
let mut http = hyper::client::HttpConnector::new();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at this connections for a while so pardon my lack of understanding here, but what is the difference here, using the HttpConnector?

@tiagolobocastro
Copy link

@Johnaius we're moving away from this repo, and keeping the templates on the control-plane repo itself, see: openebs/mayastor-control-plane#879

@Johnaius
Copy link
Author

@tiagolobocastro I searched the slack but couldn't find any discussion regarding this change and curious to hear the reasons? I saw that you've been working on the paperclip repo for a bit and just wanted to ask if this has been the plan all along and the thought process behind it.

@tiagolobocastro
Copy link

Sure, I can give you some back history as well.
Initially we started the other way around, generating openapi spec from code, using paperclip.
This became a bit cumbersome because we weren't able to easily collaborate on the openapi spec changes, since that was an artefact and not the source.
Unfortunately at the time paperclip did not support generating server code from the spec. So we forked this repo in order to be able to keep the existing code pretty much unchanged.
But then this also became a pain, because we have to build it and also making changes to the generated code (required when libraries api change) also requires modifying this repo.
So now with paperclip we can generate the same exact code again, and keep the templates in our control plane repo, which was already immensely useful when upgrading the dependencies recently.
Hope this helps, let me know if you need any help.
Now you'd need to apply your changes here in the control plane repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants