style: use rust stable for linting #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
requested review from
Abhinandan-Purkait,
abhilashshetty04 and
dsharma-dc
|
Ah seems the rust-style (aka rustfmt) still needs the nightly :( |
tiagolobocastro
force-pushed
the
rust-stable
branch
from
222c86d to
d62aa42
Compare
|
I don't think we're loosing much, other than |
tiagolobocastro
force-pushed
the
rust-stable
branch
from
d62aa42 to
1821cfe
Compare
Abhinandan-Purkait
approved these changes
Nov 21, 2024
tiagolobocastro
force-pushed
the
rust-stable
branch
from
1821cfe to
b172dd1
Compare
tiagolobocastro
changed the title
dsharma-dc
approved these changes
Nov 26, 2024
sinhaashish
approved these changes
Nov 26, 2024
tiagolobocastro
force-pushed
the
rust-stable
branch
from
b172dd1 to
242f04a
Compare
abhilashshetty04
approved these changes
Nov 26, 2024
Nightly clippy is no longer required, so we can remove its requirement and thus simplify the devel rather than require using both stable and nightly compiler. Nightly fmt is still required, but since the options we need are still not stable, I think it's better to drop them for a more mainstream approach. This should also reduce the target/debug size as there'll be only builds from one compiler. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
rust-stable
branch
from
242f04a to
3a6eb47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly clippy is no longer required, so we can remove its
requirement and thus simplify the devel rather than require using both
stable and nightly compiler.
Nightly fmt is still required, but since the options we need are still not
stable, I think it's better to drop them for a more mainstream approach.
This should also reduce the target/debug size as there'll be only
builds from one compiler.