blobstore: error code for out-of-metadata condition

Previously, when a blob store ran out of free metadata page during volume creation, an ambigious ENOMEM error was returned. Now, in order to allow to have meaningful client-faced error message and codes, EMFILE is returned instead. Signed-off-by: Dmitry Savitskiy <[email protected]>
openebs · May 9, 2024 · 5e0b422 · 5e0b422
1 parent 6bc564c
commit 5e0b422
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/blob/blobstore.c b/lib/blob/blobstore.c
@@ -6255,10 +6255,12 @@ bs_create_blob(struct spdk_blob_store *bs,
 	spdk_spin_lock(&bs->used_lock);
 	page_idx = spdk_bit_array_find_first_clear(bs->used_md_pages, 0);
 	if (page_idx == UINT32_MAX) {
+		SPDK_ERRLOG("Failed to allocate metadata for a new blob\n");
 		spdk_spin_unlock(&bs->used_lock);
-		cb_fn(cb_arg, 0, -ENOMEM);
+		cb_fn(cb_arg, 0, -EMFILE);
 		return;
 	}
+
 	spdk_bit_array_set(bs->used_blobids, page_idx);
 	bs_claim_md_page(bs, page_idx);
 	spdk_spin_unlock(&bs->used_lock);