Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bs): correctly passing additional I/O flags to blob store #27

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

dsavitskiy
Copy link
Collaborator

No description provided.

@dsavitskiy
Copy link
Collaborator Author

A flag that is used to determine unallocated blocks for rebuild of thin-provisioned volumes, was passed to Blobstore internals incorrectly. This only happened for recursive code path, which works for snapshots only. It didn’t happen for thin provisioned vol code path, as it does not go recursively into underlying blobstore (it terminates in special zero-filled blob store instead).

Because of that, an invalid value could sometimes be read from that flag, resulting in read I/O failure with false DeallocatedOrUnwrittenBlock error. Potentially, as a pointer to an incompatible struct was dereferenced, it could crash.

@dsavitskiy dsavitskiy merged commit 4b3b937 into v23.01.x-mayastor Jul 11, 2023
@dsavitskiy dsavitskiy deleted the fix-bs-flags branch July 11, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants