fix(blobstore): snapshot removal now properly ordered upon blobstore delete #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delete Snapshots are now always deleted after all existing non-snapshot lvols when removing a blobstore. Signed-off-by: Mikhail Tcymbaliuk <[email protected]>
mtzaurus
requested review from
dsavitskiy,
tiagolobocastro,
hrudaya21 and
chriswldenyer
dsavitskiy
approved these changes
Jul 14, 2023
module/bdev/lvol/vbdev_lvol.c
Outdated
| case DELETE_LVS: | ||
| if (!TAILQ_EMPTY(&lvs->lvols)) { | ||
| SPDK_ERRLOG("Lvols left in lvs ('%s'), but unable to delete.\n", lvs->name); | ||
| assert(false); |
There was a problem hiding this comment.
Can we handle this more gracefully, complete with an error rather than assert?
There was a problem hiding this comment.
I tried to preserve original logic here: if this assertion triggers, this means that forced lvol removal doesn't work and it might be a symptom of a problem.
There was a problem hiding this comment.
I see, though crashing will bring everything down only to crash again next time we try to delete?
There was a problem hiding this comment.
But maybe you. are right - let's be not too strict and issue warning.
tiagolobocastro
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshots are now always deleted after all existing non-snapshot lvols when removing a blobstore.