fix(blobstore): deallocate blob clusters when blob creation fails #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now all clusters that are owned by a blob are properly-dellocated when blob creation fails. Prior to this fix, blobstore could have dangling used clusters which remain allocated even if there is no blob that owns them. Signed-off-by: Mikhail Tcymbaliuk <[email protected]>
mtzaurus
requested review from
dsavitskiy,
tiagolobocastro,
hrudaya21 and
chriswldenyer
hrudaya21
approved these changes
Jul 20, 2023
hrudaya21
reviewed
Jul 20, 2023
tiagolobocastro
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now all clusters that are owned by a blob are properly-dellocated when blob creation fails. Prior to this fix, blobstore could have dangling used clusters which remain allocated even if there is no blob that owns them.