Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle lba range validity on ancestors with smaller sizes #47

Merged
merged 2 commits into from
May 10, 2024
Merged

fix: handle lba range validity on ancestors with smaller sizes #47

merged 2 commits into from
May 10, 2024

Conversation

dsharma-dc
Copy link
Collaborator

@dsharma-dc dsharma-dc commented May 3, 2024 •
edited
Loading

  • Do valid cluster range check while handling SPDK_NVME_IO_FLAGS_UNWRITTEN_READ_FAIL
  • While traversing back bs_devs during zeroes check or translate, do the range valid check for every bs_dev.

@dsharma-dc dsharma-dc force-pushed the ancestor_lba_resize branch 3 times, most recently from 3346f70 to a32183c Compare May 3, 2024 11:35
tiagolobocastro
tiagolobocastro reviewed May 7, 2024
View reviewed changes
Copy link

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get this reviewed by SPDK folk first again

lib/blob/blobstore.c Show resolved Hide resolved
lib/blob/blob_bs_dev.c Show resolved Hide resolved
@dsharma-dc
Copy link
Collaborator Author

Should we get this reviewed by SPDK folk first again

@tiagolobocastro It's in review there. I had created a parallel PR there as well.

@tiagolobocastro
Copy link

Please raise this against 24 as well

@dsharma-dc
fix: handle lba range validity on ancestors with smaller sizes
da8ac88 
Do valid cluster range while handling SPDK_NVME_IO_FLAGS_UNWRITTEN_READ_FAIL

Signed-off-by: Diwakar Sharma <[email protected]>
@dsharma-dc
fix: handle chain of snapshots for valid lba range
e17e9cd 
While traversing back bs_devs during zeroes check or translate,
do the range valid check for every bs_dev.

Signed-off-by: Diwakar Sharma <[email protected]>
@dsavitskiy dsavitskiy merged commit a56cdf9 into v23.05.x-mayastor May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsavitskiy dsavitskiy dsavitskiy approved these changes

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@hrudaya21 hrudaya21 hrudaya21 approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Awaiting requested review from Abhinandan-Purkait

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsharma-dc @tiagolobocastro @dsavitskiy @hrudaya21