Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdev: propagate child I/O error for split I/O #51

Merged
merged 1 commit into from
Jul 21, 2024
Merged

bdev: propagate child I/O error for split I/O #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion lib/bdev/bdev.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3309,6 +3309,17 @@ bdev_io_complete_parent_sequence_cb(void *ctx, int status)
parent_bdev_io_complete(bdev_io, status);
}

/*
* Determines if bdev_io has no space error status.
*/
static bool
_is_no_space_error(struct spdk_bdev_io *bdev_io)
{
return bdev_io->internal.status == SPDK_BDEV_IO_STATUS_NVME_ERROR &&
bdev_io->internal.error.nvme.sct == SPDK_NVME_SCT_VENDOR_SPECIFIC &&
bdev_io->internal.error.nvme.sc == ENOSPC;
}

static void
bdev_io_split_done(struct spdk_bdev_io *bdev_io, bool success, void *cb_arg)
{
Expand All @@ -3317,7 +3328,17 @@ bdev_io_split_done(struct spdk_bdev_io *bdev_io, bool success, void *cb_arg)
spdk_bdev_free_io(bdev_io);

if (!success) {
parent_io->internal.status = SPDK_BDEV_IO_STATUS_FAILED;
/*
* Propagate the last child error, unless it is ENOSPC.
* ENOSPC takes lower precedence because it may hide
* a more important failure.
*/
if (parent_io->internal.status == SPDK_BDEV_IO_STATUS_SUCCESS ||
!_is_no_space_error(bdev_io)) {
parent_io->internal.status = bdev_io->internal.status;
parent_io->internal.error = bdev_io->internal.error;
}

/* If any child I/O failed, stop further splitting process. */
parent_io->u.bdev.split_current_offset_blocks += parent_io->u.bdev.split_remaining_num_blocks;
parent_io->u.bdev.split_remaining_num_blocks = 0;
Expand Down
Loading