Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: restructured local engine (hostpath, lvm, and zfs) #404

Merged
merged 11 commits into from
Apr 5, 2024

Conversation

datacore-gthomas
Copy link
Contributor

No description provided.

@datacore-gthomas
Copy link
Contributor Author

Hello @avishnu, please review the suggested changes and share your feedback if any, or approve the PR.

If all looks good, please merge the PR by EOB. Thanks!

@balaharish7 @Abhinandan-Purkait

Signed-off-by: Gincy Thomas <[email protected]>
@avishnu
Copy link
Member

avishnu commented Apr 5, 2024

@Abhinandan-Purkait @niladrih this PR has package-lock.json and yarn.lock changes. Though they might have ended up here un-intentionally, wondering if we should consider taking in the changes as they seem to be updating lots of packages IIANW

Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the package updates -- the sample seems to build, looks fine. So I'd say it's a good idea to take this in. Should be a separate commit though, so that we could revert it if something breaks.

@avishnu
Copy link
Member

avishnu commented Apr 5, 2024

On the package updates -- the sample seems to build, looks fine. So I'd say it's a good idea to take this in. Should be a separate commit though, so that we could revert it if something breaks.

You mean both package-lock.json and yarn.lock?

@Abhinandan-Purkait
Copy link
Member

On the package updates -- the sample seems to build, looks fine. So I'd say it's a good idea to take this in. Should be a separate commit though, so that we could revert it if something breaks.

No we aren't suppose to take that in. It got created because they ran the server locally,

Copy link
Member

@avishnu avishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good PR.

@avishnu avishnu merged commit f42c6f1 into openebs:main Apr 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants