Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

chore: learner feedback collection from the mobile app #1819

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

saeedbashir
Copy link
Contributor

Description

LEARNER-9833

@@ -103,6 +103,7 @@ public enum AnalyticsDisplayName : String {
case PrivacyPolicyClicked = "Privacy Policy Clicked"
case CookiePolicyClicked = "Cookie Policy Clicked"
case DataSellConsentClicked = "Do Not Sell Data Clicked"
case SubmitFeedbackCLicked = "Submit feedback clicked"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: SubmitFeedbackCLicked to SubmitFeedbackClicked

@@ -194,6 +195,7 @@ public enum AnalyticsEventName: String {
case PrivacyPolicyClicked = "edx.bi.app.profile.privacy_policy.clicked"
case CookiePolicyClicked = "edx.bi.app.profile.cookie_policy.clicked"
case DataSellConsentClicked = "edx.bi.app.profile.do_not_sell_data.clicked"
case SubmitFeedbackCLicked = "edx.bi.app.profile.submit_feedback.clicked"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: SubmitFeedbackCLicked to SubmitFeedbackClicked

Copy link
Contributor

@shafqat-muneer shafqat-muneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saeedbashir saeedbashir merged commit 5b53fca into master Feb 15, 2024
2 of 6 checks passed
@saeedbashir saeedbashir deleted the saeed/LEARNER-9833 branch February 15, 2024 05:49
saeedbashir added a commit that referenced this pull request Feb 15, 2024
saeedbashir added a commit that referenced this pull request Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants