feat: set publish date in future for scheduled state variants #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfaqShuaib09
force-pushed
the
afaq/prod-4185
branch
from
822a1f9
to
0780007
Compare
AfaqShuaib09
commented
Oct 2, 2024
Comment on lines
-2603
to
-2609
| # Use external course availability for ExecEd course run types | ||
| # Check additional_metadata existence as a fail safe for some unit tests | ||
| # where this flow is triggered via signals before AdditionalMetadata object can be persisted | ||
| if self.type.slug in [CourseRunType.UNPAID_EXECUTIVE_EDUCATION, CourseRunType.PAID_EXECUTIVE_EDUCATION] and \ | ||
| self.course.additional_metadata: | ||
| return self.external_course_availability | ||
|
|
There was a problem hiding this comment.
This customized logic won't be required now. As we have moved Course Run's data for ExecEd from AdditionalMetadata to CourseRun model just like OCs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-4185
This PR set publish date in future for scheduled state execed variants to support future variants feature.