Fix pylint_django_settings plugin #35497
Open
+51
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfarhan943
force-pushed
the
farhan/fix-pylint-django-settings-plugin
branch
4 times, most recently
from
99b7e7f
to
8c4d530
Compare
mfarhan943
force-pushed
the
farhan/fix-pylint-django-settings-plugin
branch
from
8c4d530
to
6974e9e
Compare
UsamaSadiq
reviewed
Oct 9, 2024
|
|
||
|
|
||
| def register(linter): | ||
| linter.register_checker(SetDjangoSettingsChecker(linter)) | ||
| """ |
There was a problem hiding this comment.
Is this placeholder function still needed?
There was a problem hiding this comment.
Yes, the register function is still needed. Pylint requires it to recognize and integrate the pylint_django_settings plugin properly. Without it, Pylint raises an AttributeError. Defining the register function resolves this issue.
mfarhan943
force-pushed
the
farhan/fix-pylint-django-settings-plugin
branch
from
52e4f02
to
6974e9e
Compare
mfarhan943
force-pushed
the
farhan/fix-pylint-django-settings-plugin
branch
from
6974e9e
to
820d640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the issue with the pylint_django_settings plugin by utilizing the load_configuration(linter) method to dynamically update the DJANGO_SETTINGS_MODULE based on the command-line argument.
Supporting information
#31198