refactor: remove PII from log messages in programs tasks #35623
+34
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinhynes
commented
Oct 9, 2024
Comment on lines
-406
to
+408
| LOGGER.warning(f"User {student} is not eligible for any new program certificates") | ||
| LOGGER.warning(f"User {student.id} is not eligible for any new program certificates") | ||
|
|
||
| LOGGER.info(f"Successfully completed the task award_program_certificates for user {student}") | ||
| LOGGER.info(f"Successfully completed the task award_program_certificates for user {student.id}") |
There was a problem hiding this comment.
I thought about changing these to debug statements, or even removing them, but was trying to be wary about making too many changes.
These log statements come from a time when we had a lot less visibility/understanding of all of our edxapp-to-credentials communication issues, but seem like they are less useful or awfully noisy now.
justinhynes
commented
Oct 9, 2024
Comment on lines
-714
to
+716
| LOGGER.info(f"No program certificates to revoke from user {student}") | ||
| LOGGER.info(f"No program certificates to revoke from user {student.id}") | ||
|
|
||
| LOGGER.info(f"Successfully completed the task revoke_program_certificates for user {student}") | ||
| LOGGER.info(f"Successfully completed the task revoke_program_certificates for user {student.id}") |
There was a problem hiding this comment.
Had the same thoughts here as above...
[APER-3723] Refactors a number of log statements from the Celery tasks in the Programs Django app. This removes username (considered PII) from the log statements and opts to use LMS User ID instead.
justinhynes
force-pushed
the
jhynes/APER-3723_remove-pii-from-log
branch
from
bc11f5a
to
f84cb48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[APER-3723]
Refactors a number of log statements from the Celery tasks in the Programs Django app. This removes username from the log statements and opts to use the LMS User ID instead.