Limit the rate of logins #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self._assert_response(response, success=True) | ||
|
|
||
| def test_login_ratelimited(self): | ||
| # try logging in 30 times |
There was a problem hiding this comment.
comment doesn't match the code
|
Okay, I've addressed all the current comments. Could you take another look? |
| try: | ||
| user = authenticate(username=username, password=password, request=request) | ||
| except RateLimitException: | ||
| log.warning('OpendID - Too many failed login attempts.') |
There was a problem hiding this comment.
s/OpendID/OpenId/. Also, shouldn't this write to AUDIT_LOG instead of log?
|
Looks good.... |
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
…file-view Set request.user = student when impersonating a student
caesar2164
added a commit
to caesar2164/edx-platform
that referenced
this pull request
Jan 24, 2017
…eoquiz-version Push up to version 0.1.2 of in video quiz
jfavellar90
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Apr 11, 2018
ENH: grades now returned on a hierarchical level bases.
dgamanenko
referenced
this pull request
in raccoongang/edx-platform
Jun 14, 2018
ENH: grades now returned on a hierarchical level bases.
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
…edx#554) In https://github.com/edx/edx-platform/pull/28233, the logic was updated to only return a URL if the content was still accessible to the learner. This handles the case of the URL being null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds rate limiting to our authentication backend.
This pull request covers:
These things are deliberately not tested after talking to Test Engineering:
This does not cover additional work needed for logging, since that relies on pull request 539 to implemented.
@brianhw @nedbat , review?