Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testiing Reduce css #1047

Closed

Conversation

ghassanmas
Copy link
Member

@ghassanmas ghassanmas commented Jan 18, 2023

This is opened only for testing purpose regarding openedx/frontend-build/pull/266

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 18, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 18, 2023

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@ghassanmas ghassanmas changed the base branch from master to open-release/olive.master January 18, 2023 16:05
@ghassanmas ghassanmas marked this pull request as draft January 18, 2023 16:38
@e0d
Copy link

e0d commented Jan 20, 2023

@ghassanmas this is interesting work. Should this be a draft PR? It's helpful for us that PRs remain in a draft state until they are ready for review.

@ghassanmas
Copy link
Member Author

@e0d initially I opened this PR to ease the testing of openedx/frontend-build#266
If it get merged then I would need to update this PR to point the latest frontend-build as opposite to my git fork, but then that would require extra work because currently learning MFE is behind 2 version of frontend-build, where the new version of front-build require new/different eslint roles/version.

@itsjeyd itsjeyd added blocked by other work PR cannot be finished until other work is complete core committer labels Jan 24, 2023
@itsjeyd
Copy link

itsjeyd commented Mar 28, 2023

label: core contributor

@github-actions github-actions bot added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Mar 28, 2023
@itsjeyd
Copy link

itsjeyd commented Apr 5, 2023

Hey @ghassanmas, now that openedx/frontend-build#266 has been merged (🎉), will you be picking up work on this PR again?

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed blocked by other work PR cannot be finished until other work is complete labels Apr 5, 2023
@itsjeyd
Copy link

itsjeyd commented Apr 13, 2023

@ghassanmas A friendly ping about my previous comment.

@ghassanmas
Copy link
Member Author

@itsjeyd Sorry for the late reply. And thank you for the reminder.
For the learning MFE to utilize the new feature it just need to use frontend-build version >12.8.0 ref. Which is not the case yet!

I can open a new PR to upgrade it but I suspect it will be relate to this PR #1084. So it's best in terms of reducing friction, merge conflict...etc That if #1084 would also update front-build to at least 12.8.0, given from version > 12.7.0 ref frontend-build is upgraded to use node 18. Also that PR is already tracked to be included in Palm in openedx/wg-build-test-release/issues/261.

Moving forward, I will close this PR, and I will comment on the referred PR #1084 to ask if it's possible to upgrade frontend-build, I will also check frontend-build version for other MFEs to ensure this feature is available for palm.

@ghassanmas ghassanmas closed this Apr 15, 2023
@openedx-webhooks
Copy link

@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd
Copy link

itsjeyd commented Apr 20, 2023

No worries, and thanks for the detailed update @ghassanmas! :)

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants