Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync LMS_BASE_URL for bookmark API if changed (backport) #1123

Conversation

regisb
Copy link

@regisb regisb commented Jun 1, 2023

This is a backport of the following PR: #1120

===========================

This change makes it possible to use the latest LMS_BASE_API
if it was changed because of dynamic config API, which is the
default case of tutor.

This changes closes openedx/wg-build-test-release/issues/270

Fixes that are simlar to this

  This change makes it possible to use the latest  LMS_BASE_API
  if it was changed because of dynamic config API, which is the
  default case of tutor.

  This changes closes openedx/wg-build-test-release/issues/270

   Fixes that are simlar to this
  - gradebook openedx/frontend-app-gradebook/pull/290
  - course authoring openedx/frontend-app-authoring/pull/389
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core committer labels Jun 1, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @regisb!

As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (open-release/palm.master@757d967). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             open-release/palm.master    #1123   +/-   ##
===========================================================
  Coverage                            ?   87.03%           
===========================================================
  Files                               ?      253           
  Lines                               ?     4366           
  Branches                            ?     1105           
===========================================================
  Hits                                ?     3800           
  Misses                              ?      547           
  Partials                            ?       19           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arbrandes arbrandes merged commit 2213d45 into openedx:open-release/palm.master Jun 1, 2023
@openedx-webhooks
Copy link

@regisb 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@regisb regisb deleted the regisb/backport-bookmarks-fix branch June 6, 2023 08:58
@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). and removed core committer labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants