Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for pollAttempt fail in courseview #142

Merged
merged 5 commits into from
Mar 21, 2024

Commits on Mar 14, 2024

  1. fix: workaround for pollAttempt fail in courseview

    - Combined fetchActiveAttempt &  fetchLatestExamAttempt into one function with an optional "sequenceId" variable. At the very least, this works without causing errors in non-exam-sequence views. Since the sequenceId is undefined in that case, due to the sequenceId needing to be extracted from the sequence page itself, we can at least still get the latest exam attempt data.
    - To my best knowledge, we originally called for the attempt of an exam with a given sequenceId in order to get the latest attempt for an exam regardless of whether or not its active, such that the timer can be seen on non exam-sequence pages. However, we don't truly need the sequence_id for this.
    - It's also possible that this was also designed this way so that we could make sure a learner hadn't started two exams at once, and so their "latest exam attempt" would pretain to the exam they started most recently. We already have safeguards for this in edx_exams (See: https://github.com/edx/edx-exams/blob/main/edx_exams/apps/core/api.py#L201).
    ilee2u committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    dacc6e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    1ca8517 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. test: fixed tests to match new code

    - also removed timerEnds param from TimerProvider useEffect, replaced it with a lint ignore
    ilee2u committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    be138b5 View commit details
    Browse the repository at this point in the history
  2. chore: remove extra comments

    ilee2u committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    47bb4a7 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Configuration menu
    Copy the full SHA
    620f89b View commit details
    Browse the repository at this point in the history