Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop python3.8 version in all CI/CD workflows and implementation #398

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Sep 16, 2024

Description

This is another PR dropping python3.8 in files I missed while updating to python3.8 here #392. Mainly, this PR updates .readthedocs.yml so it builds using python3.11, solving: #397. You can see a successful run in this draft PR: #399

This is hopefully the last PR about Python3.8. Please, let me know if you find any other references.

@openedx-webhooks
Copy link

openedx-webhooks commented Sep 16, 2024

Thanks for the pull request, @mariajgrimaldi!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/hooks-extension-framework. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 16, 2024
@mariajgrimaldi mariajgrimaldi changed the title build: upgrade python/ubuntu version for readthedocs build process build: upgrade python version for readthedocs build process Sep 16, 2024
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/update-readthedocs branch 3 times, most recently from c4f85a9 to e8af481 Compare September 16, 2024 18:06
@mariajgrimaldi mariajgrimaldi changed the title build: upgrade python version for readthedocs build process build: upgrade python version in all CI/CD workflows and implementation Sep 16, 2024
@mariajgrimaldi mariajgrimaldi changed the title build: upgrade python version in all CI/CD workflows and implementation build: drop python3.8 version in all CI/CD workflows and implementation Sep 16, 2024
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review September 16, 2024 18:11
@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner September 16, 2024 18:11
@felipemontoya
Copy link
Member

linking #393 for reference

Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should move this reference as well:

python_requires=">=3.8",
?

@mariajgrimaldi
Copy link
Member Author

mariajgrimaldi commented Sep 23, 2024

@felipemontoya: done, thanks for the suggestion! Could you review it again, please?

Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mariajgrimaldi mariajgrimaldi merged commit 52e9d21 into main Sep 23, 2024
8 checks passed
@mariajgrimaldi mariajgrimaldi deleted the MJG/update-readthedocs branch September 23, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants