Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgraded to node v18, added .nvmrc and updated workflows #2145

Closed
wants to merge 9 commits into from

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Mar 17, 2023

Ticket
Upgrade Node JS from 16 to 18

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit a669157
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6438f74f34189000089751b6
😎 Deploy Preview https://deploy-preview-2145--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (987d421) 90.97% compared to head (c614d02) 90.97%.

❗ Current head c614d02 differs from pull request most recent head a669157. Consider uploading reports for the commit a669157 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2145   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files         234      234           
  Lines        4120     4120           
  Branches      979      979           
=======================================
  Hits         3748     3748           
  Misses        365      365           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mashal-m Mashal-m closed this Mar 24, 2023
@Mashal-m Mashal-m reopened this Mar 24, 2023
@Mashal-m Mashal-m marked this pull request as ready for review March 27, 2023 09:52
@Mashal-m Mashal-m marked this pull request as draft April 20, 2023 11:42
@Mashal-m Mashal-m closed this Apr 25, 2023
@Mashal-m
Copy link
Contributor Author

Closing this because of many conflicts, created a new PR for the same work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant