-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrations to make it compatible with mysql and postgresql #511
fix: migrations to make it compatible with mysql and postgresql #511
Conversation
Thanks for the pull request, @qasimgulzar! This repository is currently maintained by @openedx/openedx-unmaintained. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
@@ -27,7 +27,7 @@ | |||
FROM | |||
lti_consumer_lticonfiguration | |||
WHERE | |||
config_id = "" | |||
config_id = '00000000-0000-0000-0000-000000000000' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the behavior of this backfill would get altered by this, but this backfill only applies to MySQL in the first place (since PostgreSQL would be new, we'd never get into this weird state of needing to backfill in blank entries). So instead of altering the field we're searching on, maybe we could just skip the backfills entirely if we detect that the database being used is PostgreSQL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, actually postgrsql consider double quotes wrapped string as a column name, I have switched it to single quotes which is considered as values for both dialect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated this line.
@ormsbee can you trigger the workflows here? |
4a69383
to
44271dd
Compare
@ormsbee flagging this, in case you're able to review! |
No description provided.