Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove yanked codecov package (and coverage upload) #886

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

timmc-edx
Copy link
Contributor

@timmc-edx timmc-edx commented Apr 13, 2023

Stop trying to install the deprecated (and now yanked) codecov package. Also remove the CI step that was trying to use it, since we'd prefer to unblock CI now and restore coverage later. #887 tracks restoring coverage testing.

I guess this repo isn't using the newer github action, but adding that can
be a different task if we decide to continue with codecov.
robrap
robrap previously approved these changes Apr 13, 2023
@timmc-edx
Copy link
Contributor Author

Hmm, looks like it was actually still invoking codecov:

docker exec xqueue bash -c "cd /edx/app/xqueue/xqueue/; coverage xml" && codecov

Maybe we want to just remove that coverage step for now.

@robrap
Copy link
Contributor

robrap commented Apr 13, 2023

Can it just do what other services are doing?

@timmc-edx
Copy link
Contributor Author

It's doing all of its tests inside a docker container for some reason. The other repos that use the coverage action are able to do so because they're not running tests that way.

@robrap
Copy link
Contributor

robrap commented Apr 13, 2023

Maybe just drop coverage and add an issue for changing this to better match other repos?

@timmc-edx
Copy link
Contributor Author

Yeah, I think that's the best route. It looks like we should be able to generate a coverage report inside the container, copy the files out of the container, and then run the action -- but I'd like to figure that out a different day. :-)

@timmc-edx
Copy link
Contributor Author

Created tracking issue: #887

#887 tracks restoring and fixing
coverage testing.
@timmc-edx timmc-edx changed the title fix: Remove yanked codecov package fix: Remove yanked codecov package (and coverage upload) Apr 13, 2023
@timmc-edx timmc-edx changed the title fix: Remove yanked codecov package (and coverage upload) build: Remove yanked codecov package (and coverage upload) Apr 13, 2023
@timmc-edx
Copy link
Contributor Author

@robrap Ready for re-review.

@timmc-edx timmc-edx merged commit 592888d into master Apr 14, 2023
@timmc-edx timmc-edx deleted the timmc/no-codecov branch April 14, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants