fix 'find uses' feature failing from 4.3 onwards #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_all_user_name_fields() was deprecated in 3.11, became an error- emitting stub in 4.3, and was removed fully in 4.5.
|
Excellent, thank you @usqfowlerj ! Great to see you kept the backwards compatibility too. We're currently discussing plans for the next release of the moodle module. So I'll just hold this here for the moment while we do that. Thank you. 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
get_all_user_name_fields() was deprecated in 3.11, became an error-emitting stub in 4.3, and was removed fully in 4.5.