Delete stale templates after each build. #1550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template files have a habit of sticking around in the output folder, even if the project no longer needs or wants them. Clearing old templates can improve app stability.
|
The conditional compilation block is going to prevent CI from noticing the change. (But if it weren't there, it would crash because CI still uses HXP 1.2.2.) If you want to test this yourself, make sure to pull my HXP branch, open HXP's haxelib.json file, and set |
player-03
changed the title
|
Update: I think the new pull request is a better approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template files have a habit of sticking around in the output folder, even if the project no longer needs or wants them. Clearing old templates can improve app stability.
Like #1547, this is one half of a potential solution to #1546. (The other half is openfl/hxp#28.) And I'd argue it's a better solution, requiring less maintenance and not forcing users to update hxp at the same time as Lime.