Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -json flag to allow json types creation #1882

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

ninjamuffin99
Copy link
Contributor

Along with type information in XML format, Haxe also supports type information in JSON format. So this change is simple and follows along wherever if (project.targetFlags.exists("xml")) is and we just check for a json flag as well.

@moxie-coder
Copy link

Along with type information in XML format, Haxe also supports type information in JSON format. So this change is simple and follows along wherever if (project.targetFlags.exists("xml")) is and we just check for a json flag as well.

considerably, how much modular would this be than XML/HXP?

@joshtynjala
Copy link
Member

Hmmm... oddly, I don't see the --json flag in the official Haxe compiler usage documentation:

https://haxe.org/manual/compiler-usage.html

Is it new in Haxe 5?

@ninjamuffin99
Copy link
Contributor Author

seems like it's not in the documentation, but at least as of 4.3.6 (my current installation) haxe --help shows it

Services:
  --display                             display code tips
  --xml <file>                          generate XML types description
  --json <file>                         generate JSON types description

@ninjamuffin99
Copy link
Contributor Author

Along with type information in XML format, Haxe also supports type information in JSON format. So this change is simple and follows along wherever if (project.targetFlags.exists("xml")) is and we just check for a json flag as well.

considerably, how much modular would this be than XML/HXP?

I think it enables more possibilities for documentation, as JSON is pretty widely used these days, and tool support for managing and working with JSON I feel is more easily available / usable.

@moxie-coder
Copy link

Along with type information in XML format, Haxe also supports type information in JSON format. So this change is simple and follows along wherever if (project.targetFlags.exists("xml")) is and we just check for a json flag as well.

considerably, how much modular would this be than XML/HXP?

I think it enables more possibilities for documentation, as JSON is pretty widely used these days, and tool support for managing and working with JSON I feel is more easily available / usable.

sounds good to me

@joshtynjala
Copy link
Member

seems like it's not in the documentation, but at least as of 4.3.6 (my current installation) haxe --help shows it

Thanks. Seems reasonable to me to add this one in a feature update. Maybe 8.3.

@joshtynjala joshtynjala changed the base branch from develop to 8.3.0-Dev January 10, 2025 23:07
@joshtynjala joshtynjala changed the base branch from 8.3.0-Dev to develop January 10, 2025 23:08
@joshtynjala joshtynjala changed the base branch from develop to 8.3.0-Dev January 10, 2025 23:09
@joshtynjala joshtynjala merged commit 03ea041 into openfl:8.3.0-Dev Jan 10, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants