Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix robotoff API call for countries #1002

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Jul 22, 2024

Fix #1001

Use an intermediate function to convert id (en:France) to code (FR)

@raphael0202 is it case-sensitive?

After trying, it is 🙈 so I lowercased everything

For example,

https://deploy-preview-1002--warm-cannoli-79bbb2.netlify.app/questions?country=en%3Aaustria

is calling

https://robotoff.openfoodfacts.org/api/v1/questions/?countries=at&order_by=popularity&lang=en&count=25&page=1

@alexfauquette alexfauquette requested a review from a team as a code owner July 22, 2024 17:17
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for warm-cannoli-79bbb2 ready!

Name Link
🔨 Latest commit f157907
🔍 Latest deploy log https://app.netlify.com/sites/warm-cannoli-79bbb2/deploys/669e94e5756f2f00083610e4
😎 Deploy Preview https://deploy-preview-1002--warm-cannoli-79bbb2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the GitHub Actions Pull requests that update GitHub Actions code label Jul 22, 2024
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexfauquette
Given the impact, I'm speedy merging 👍

@teolemon teolemon merged commit 18483aa into openfoodfacts:master Jul 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions Pull requests that update GitHub Actions code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use parameters countries= when fetching insights
2 participants