aligned loader center while loading pages #674
Conversation
|
Supersedes #669 |
src/App.jsx
Outdated
| @@ -45,6 +44,7 @@ const LogoQuestionValidator = React.lazy(() => | |||
| import("./pages/logosValidator/LogoQuestionValidator") | |||
| ); | |||
| const DashBoard = React.lazy(() => import("./pages/logosValidator/DashBoard")); | |||
| const Loader = React.lazy(() => import("./pages/loader")); | |||
There was a problem hiding this comment.
I would import this statically, as it should be only a few Bytes and using a dynamic import for a fallback seems counterintuitive.
There was a problem hiding this comment.
@VaiTon there is index.jsx page in pages folder which is importing all the pages ! I think we don't need that file anymore as we are importing everything directly in the app.jsx file.
There was a problem hiding this comment.
i had imported everywhere statically, this ones left, i will change that
There was a problem hiding this comment.
I mean this file : https://github.com/openfoodfacts/hunger-games/blob/master/src/pages/index.jsx
We don't need this anymore
There was a problem hiding this comment.
@Sudhanva-Nadiger let's make that another PR
There was a problem hiding this comment.
Okay ! Cool ! Shall I open a issue ?
There was a problem hiding this comment.
You could even directly open a PR
There was a problem hiding this comment.
@VaiTon the pr is ready :)
What
Created Loader Component and added it in all the pages
Screenshot
Fixes Issue
#668