Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove react-scripts dependency #681

Merged
merged 1 commit into from
Jul 18, 2023
Merged

chore: remove react-scripts dependency #681

merged 1 commit into from
Jul 18, 2023

Conversation

VaiTon
Copy link
Member

@VaiTon VaiTon commented Jul 14, 2023

As we're now using Vite, we don't need that dependency.

@VaiTon VaiTon requested a review from a team as a code owner July 14, 2023 15:42
alexfauquette
alexfauquette approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it will remove some false positives about security

@VaiTon VaiTon merged commit 866b204 into master Jul 18, 2023
8 checks passed
@VaiTon VaiTon deleted the remove/react-scripts branch July 18, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@VaiTon VaiTon

Labels
None yet
Projects
Hunger Games (new)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VaiTon @alexfauquette