Fix tests

openfoodfacts · Aug 17, 2024 · 67f12be · 67f12be
1 parent 9762422
commit 67f12be
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/views/ProductDetail.vue b/src/views/ProductDetail.vue
@@ -18,7 +18,7 @@
         </p>
         <OpenFoodFactsAddMenu :productCode="productId" />
       </v-alert>
-      <v-alert v-else-if="!categoryFound" data-name="category-not-found-alert" type="error" variant="outlined" icon="mdi-alert">
+      <v-alert v-else-if="categoryNotFound" data-name="category-not-found-alert" type="error" variant="outlined" icon="mdi-alert">
         <i>{{ $t('ProductDetail.CategoryNotFound') }}</i>
       </v-alert>
     </v-col>
@@ -109,10 +109,13 @@ export default {
       return !this.productIsCategory && this.product && !this.product.source
     },
     categoryFound() {
-      return this.productIsCategory && this.category && !this.category.status
+      return this.category && !this.category.status
+    },
+    categoryNotFound() {
+      return this.productIsCategory && !this.categoryFound
     },
     productOrCategoryNotFound() {
-      return !this.loading && (this.productNotFound || !this.categoryFound)
+      return !this.loading && (this.productNotFound || this.categoryNotFound)
     },
     getPricesParams() {
       let defaultParams = { [this.productIsCategory ? 'category_tag' : 'product_code']: this.productId, order_by: `${this.currentOrder}`, page: this.productPricePage }

diff --git a/tests/e2e/spec.cy.js b/tests/e2e/spec.cy.js
@@ -43,6 +43,7 @@ describe('Basic tests', () => {
     cy.get('#price-count').contains('1')
     cy.get('[data-name="product-missing-chip"]').should('have.length', 0)
     cy.get('[data-name="product-not-found-alert"]').should('have.length', 0)
+    cy.get('[data-name="category-not-found-alert"]').should('have.length', 0)
     cy.get('[data-name="price-card"]').should('have.length', 1)
     cy.contains('Load more').should('not.exist')
   })
@@ -62,6 +63,7 @@ describe('Basic tests', () => {
     cy.get('#price-count').contains('0')
     cy.get('[data-name="product-missing-chip"]').should('have.length', 1)
     cy.get('[data-name="product-not-found-alert"]').should('have.length', 1)
+    cy.get('[data-name="category-not-found-alert"]').should('have.length', 0)
     cy.get('[data-name="price-card"]').should('have.length', 0)
     cy.contains('Load more').should('not.exist')
   })
@@ -72,6 +74,7 @@ describe('Basic tests', () => {
     cy.get('.v-card-title').contains('Pitted apricot')
     cy.get('#price-count').contains('2')
     cy.get('[data-name="product-missing-chip"]').should('have.length', 0)
+    cy.get('[data-name="product-not-found-alert"]').should('have.length', 0)
     cy.get('[data-name="category-not-found-alert"]').should('have.length', 0)
     cy.get('[data-name="price-card"]').should('have.length', 2)
     cy.contains('Load more').should('not.exist')
@@ -83,6 +86,7 @@ describe('Basic tests', () => {
     cy.get('.v-card-title').contains('en:aaaaaaaaaaaa')
     cy.get('#price-count').contains('0')
     // cy.get('[data-name="product-missing-chip"]').should('have.length', 1)
+    cy.get('[data-name="product-not-found-alert"]').should('have.length', 0)
     cy.get('[data-name="category-not-found-alert"]').should('have.length', 1)
     cy.get('[data-name="price-card"]').should('have.length', 0)
     cy.contains('Load more').should('not.exist')