feat: add category price per unit toggle #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
reviewed
Jan 31, 2024
There was a problem hiding this comment.
i see a few things missing :
- when a user submits a price -
createPrice()- with barcode, we should set theprice_perto null (currently i see aprice_per: KILOGRAMsent to the backend, there's no error but we should avoid sending it nevertheless) - we need to change the
PriceCardas well to display prices "per unit"
There was a problem hiding this comment.
and i added a screenshot (helpful for reviewers and people stumbling on the PR !)
There was a problem hiding this comment.
- that indeed happened in AddPriceMultiple. I added a cleanup in both AddPriceMultiple and AddPriceSingle for peace of mind
- PriceCard: Updated
There was a problem hiding this comment.
Kg -> kg and Unit -> unit no ?
appart from that it's mergable :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
price_perbetweenKILOGRAMorUNITwhen inputting a price for a product without barcodeScreenshot