Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: product "getAttribute" method #799

Merged

Conversation

monsieurtanuki
Copy link
Contributor

What

  • In Smoothie we needed this product.getAttribute method and had to implement it there.
  • It's cleaner if it's in off-dart.

Impacted file

  • product.dart: new getAttribute method

Impacted file:
* `product.dart`: new `getAttribute` method
@codecov-commenter
Copy link

Codecov Report

Merging #799 (fcc4d58) into master (a26ec2a) will decrease coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
- Coverage   74.87%   74.83%   -0.05%     
==========================================
  Files         199      199              
  Lines        7319     7323       +4     
==========================================
  Hits         5480     5480              
- Misses       1839     1843       +4     
Files Changed Coverage Δ
lib/src/model/product.dart 75.00% <0.00%> (-2.21%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @monsieurtanuki 👌

@monsieurtanuki monsieurtanuki merged commit a179dc5 into openfoodfacts:master Sep 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants