feat: 802 - new "get product" method specific to OBF OPF OPFF #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `api_not_food_get_product_test.dart`: tests around OBF OPF OPFF and `getOldProduct` * `old_product_result.dart`: Product Result (old style). * `old_product_result.g.dart`: generated Impacted files: * `open_food_api_client.dart`: new `getOldProduct` method, dedicated to OBF OPF OPFF, and supposed to disappear when they support API V3. * `openfoodfacts.dart`: exported new class.
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
==========================================
+ Coverage 74.80% 74.84% +0.04%
==========================================
Files 201 204 +3
Lines 7314 7375 +61
==========================================
+ Hits 5471 5520 +49
- Misses 1843 1855 +12
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you @M123-dev for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
getOldProduct, that work with OBF OPF OPFF (and also OFF).getOldProduct.Fixes bug(s)
Files
New files:
api_not_food_get_product_test.dart: tests around OBF OPF OPFF andgetOldProductold_product_result.dart: Product Result (old style).old_product_result.g.dart: generatedImpacted files:
open_food_api_client.dart: newgetOldProductmethod, dedicated to OBF OPF OPFF, and supposed to disappear when they support API V3.openfoodfacts.dart: exported new class.