fix: 970 - refactored around new Prices API #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `api_prices_test.dart`: refactored around new Prices API * `open_prices_api_client.dart`: different status code for "delete user session"; simplified `updatePrice` and `updateProof` * `price_user.dart`: field `isModerator` is now optional * `price_user.g.dart`: generated * `session.dart`: additional status codes and error messages
teolemon
approved these changes
Sep 7, 2024
|
Cc @raphodn |
|
Thanks @monsieurtanuki 🙏 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
==========================================
- Coverage 76.34% 75.47% -0.88%
==========================================
Files 239 250 +11
Lines 8494 9183 +689
==========================================
+ Hits 6485 6931 +446
- Misses 2009 2252 +243 ☔ View full report in Codecov by Sentry. |
|
Thank you @teolemon for that very fast review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes bug(s)
Impacted files
api_prices_test.dart: refactored around new Prices APIopen_prices_api_client.dart: different status code for "delete user session"; simplifiedupdatePriceandupdateProofprice_user.dart: fieldisModeratoris now optionalprice_user.g.dart: generatedsession.dart: additional status codes and error messages