feat: 978 - new prices features (thumbnails, stats) #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file: * `price_total_stats.dart`: Total stats for Prices. Impacted files: * `api_get_product_test.dart`: unrelated minor fix * `api_prices_test.dart`: added test for the new `getStats` method; added test for thumbnails * `location.dart`: added new count fields * `location.g.dart`: generated * `open_prices_api_client.dart`: new method `getStats` * `openfoodfacts.dart`: exported new file `price_total_stats.dart` * `price_product.dart`: added new count fields * `price_product.g.dart`: generated * `price_user.dart`: added new count fields * `price_user.g.dart`: generated * `proof.dart`: added thumbnail field and getter * `proof.g.dart`: generated * `proof_type.dart`: added new "SHOP_IMPORT" value
teolemon
approved these changes
Oct 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #982 +/- ##
==========================================
- Coverage 76.34% 72.66% -3.69%
==========================================
Files 239 253 +14
Lines 8494 9303 +809
==========================================
+ Hits 6485 6760 +275
- Misses 2009 2543 +534 ☔ View full report in Codecov by Sentry. |
|
Thank you @teolemon for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
SHOP_IMPORTproof typeFixes bug(s)
Files
New files:
price_total_stats.dart: Total stats for Prices.price_total_stats.g.dart: generatedImpacted files:
api_get_product_test.dart: unrelated minor fixapi_prices_test.dart: added test for the newgetStatsmethod; added test for thumbnailslocation.dart: added new count fieldslocation.g.dart: generatedopen_prices_api_client.dart: new methodgetStatsopenfoodfacts.dart: exported new fileprice_total_stats.dartprice_product.dart: added new count fieldsprice_product.g.dart: generatedprice_user.dart: added new count fieldsprice_user.g.dart: generatedproof.dart: added thumbnail field and getterproof.g.dart: generatedproof_type.dart: added new "SHOP_IMPORT" value