Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Does not recognise deletions when loading data from events #88

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

john-gom
Copy link
Collaborator

Signed-off-by: John Gomersall [email protected]

What

  • Set the obsolete flag to null if a product is deleted

Fixes bug(s)

Note doesn't actually use the event. The absence of the product in MongoDB is used to indicate it has been deleted.

@john-gom john-gom requested a review from a team as a code owner September 13, 2024 13:03
@john-gom john-gom linked an issue Sep 13, 2024 that may be closed by this pull request
@john-gom john-gom merged commit 1a8dd3a into main Sep 13, 2024
6 checks passed
@john-gom john-gom deleted the 87-does-not-deal-with-product-deletions branch September 13, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not deal with product deletions
1 participant