Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move buttons outside the search-bar #197

Merged
merged 14 commits into from
Jun 28, 2024
Merged

feat: move buttons outside the search-bar #197

merged 14 commits into from
Jun 28, 2024

Conversation

Kout95
Copy link
Collaborator

@Kout95 Kout95 commented Jun 27, 2024 •
edited
Loading

What

  • separate search-button and search-reset-button from search-bar

@Kout95 Kout95 changed the title feat: put reset button outside the search-bar feat: move buttons outside the search-bar Jun 27, 2024
@Kout95 Kout95 marked this pull request as ready for review June 27, 2024 15:06
alexgarel
alexgarel requested changes Jun 28, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That's really cool to see the pre-signal in action.

We need to keep handling search names though.

frontend/public/off.html Outdated Show resolved Hide resolved
frontend/src/mixins/search-ctl.ts
*/
get canReset() {
const isQueryChanged = this.query || this.isQueryChanged;
const facetsChanged = this._facetsFilters() || this.isFacetsChanged;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should include "sort", but it's a matter for the future ;-)

frontend/src/mixins/search-ctl.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great way of coding this interactions ! 👏

frontend/src/search-button.ts Outdated Show resolved Hide resolved
frontend/src/signals.ts Outdated Show resolved Hide resolved
frontend/src/search-reset-button.ts Show resolved Hide resolved
frontend/src/search-reset-button.ts Outdated Show resolved Hide resolved
@Kout95 Kout95 requested a review from alexgarel June 28, 2024 08:52
alexgarel
alexgarel approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

frontend/src/utils/search.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea !

@alexgarel alexgarel merged commit 3c9052c into main Jun 28, 2024
7 checks passed
@alexgarel alexgarel deleted the fix-search-bar branch June 28, 2024 10:07
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jun 28, 2024
Merged
@alexgarel alexgarel mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@Kout95 Kout95

Labels
None yet
Projects
🔎 Search-a-licious
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kout95 @alexgarel