Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: i18n are not loaded because is dynamically import #199

Merged
merged 6 commits into from
Jun 28, 2024
Merged

fix: i18n are not loaded because is dynamically import #199

merged 6 commits into from
Jun 28, 2024

Conversation

Kout95
Copy link
Collaborator

@Kout95 Kout95 commented Jun 27, 2024 •
edited
Loading

What

  • Copy generated files to public to allow bundle to import it dynamically

@Kout95 Kout95 requested a review from alexgarel June 27, 2024 16:08
@Kout95 Kout95 marked this pull request as ready for review June 27, 2024 16:12
alexgarel
alexgarel approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@alexgarel alexgarel merged commit 0bcac0e into main Jun 28, 2024
6 checks passed
@alexgarel alexgarel deleted the fix-i18n-bundle branch June 28, 2024 07:03
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@Kout95 Kout95

Labels
None yet
Projects
🔎 Search-a-licious
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kout95 @alexgarel