Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: When an image is unavailable -> find in another language #6297

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 27, 2025

HI everyone!

The same as #6293, but for the product's main picture:

  • User language
  • Default language
  • Fallback URL
  • (NEW) English
  • (NEW) Any other translation

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 5.95%. Comparing base (4d9c7fc) to head (003128c).
Report is 711 commits behind head on develop.

Files with missing lines Patch % Lines
.../lib/cards/product_cards/smooth_product_image.dart 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6297      +/-   ##
==========================================
- Coverage     9.54%   5.95%   -3.59%     
==========================================
  Files          325     472     +147     
  Lines        16411   27956   +11545     
==========================================
+ Hits          1567    1666      +99     
- Misses       14844   26290   +11446     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit b9e0a23 into openfoodfacts:develop Jan 28, 2025
6 checks passed
@g123k g123k deleted the product_picture_alt_language branch January 28, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants