Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root nodes page and search page should use the same components to display nodes #285

Closed
alexgarel opened this issue Nov 10, 2023 · 0 comments · Fixed by #290
Closed

Root nodes page and search page should use the same components to display nodes #285

alexgarel opened this issue Nov 10, 2023 · 0 comments · Fixed by #290
Assignees
@Piv94165
Labels
🐛 bug Something isn't working

Comments

@alexgarel
Copy link
Member

alexgarel commented Nov 10, 2023 •
edited by Piv94165
Loading

What

  • Right now we have quite the same list on root nodes page and search page, we should use the same component to avoid double maintenance.

Code pointers

taxonomy-editor-frontend\src\pages\search\SearchResults.tsx
taxonomy-editor-frontend\src\pages\root-nodes\index.tsx
@alexgarel alexgarel added the 🐛 bug Something isn't working label Nov 10, 2023
@Piv94165 Piv94165 self-assigned this Nov 16, 2023
@Piv94165 Piv94165 linked a pull request Nov 16, 2023 that will close this issue
refactor(taxonomy-editor-frontend): Create a component for nodes table #290
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Piv94165 Piv94165

Labels
🐛 bug Something isn't working
Projects
Taxonomy-editor - CentraleSupelec 2023
Status: History
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(taxonomy-editor-frontend): Create a component for nodes table openfoodfacts/taxonomy-editor
2 participants
@alexgarel @Piv94165