Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(taxonomy-editor-frontend): Create a component for nodes table #290

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Piv94165
Copy link
Contributor

Create a component for nodes table used in nodes and search pages

What

  • Right now we have quite the same list on root nodes page and search page, we should use the same component to avoid double maintenance.

Screenshot

no visible change

Code pointers

taxonomy-editor-frontend\src\pages\search\SearchResults.tsx
taxonomy-editor-frontend\src\pages\root-nodes\index.tsx

@Piv94165 Piv94165 force-pushed the refactor/create-component-to-display-nodes branch from e94b440 to f4add21 Compare November 16, 2023 12:51
@alexgarel
Copy link
Member

@nobeeakon would you eventually have the time to review this PR ?

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codes seems really ok and I tested it, it works.

Thanks @Piv94165 !

@alexgarel alexgarel merged commit eb2bff3 into main Nov 23, 2023
7 checks passed
@alexgarel alexgarel deleted the refactor/create-component-to-display-nodes branch November 23, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Root nodes page and search page should use the same components to display nodes
2 participants