Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Updating the dev setup #267

Merged
merged 6 commits into from
Nov 1, 2023
Merged

docs: Updating the dev setup #267

merged 6 commits into from
Nov 1, 2023

Conversation

eric-nguyen-cs
Copy link
Contributor

What

A few updates for the dev setup:

  • Migrate from the deprecated Docker Compose V1 (a Python package that relies on Python <= 3.9) to Docker Compose V2 (that comes with every Docker installation by default)
  • Update the Makefile with a few simple quality of lifechanges (with the relevant document changes)

Part of

#263

@eric-nguyen-cs eric-nguyen-cs requested a review from a team as a code owner October 26, 2023 08:12
@github-actions github-actions bot added 📚 documentation Improvements or additions to documentation parser labels Oct 26, 2023
@eric-nguyen-cs eric-nguyen-cs changed the title Updating the dev setup docs: Updating the dev setup Oct 26, 2023
alexgarel
alexgarel approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I propose a small improvement.

Makefile Outdated Show resolved Hide resolved
perierc
perierc approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@perierc perierc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@eric-nguyen-cs eric-nguyen-cs merged commit d0cbf49 into main Nov 1, 2023
7 checks passed
@eric-nguyen-cs eric-nguyen-cs deleted the ericn/start-updating-dev-setup branch November 1, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@perierc perierc perierc approved these changes

Assignees

@eric-nguyen-cs eric-nguyen-cs

Labels
📚 documentation Improvements or additions to documentation parser
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-nguyen-cs @alexgarel @perierc