Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Poetry for Python dependency management #278

Merged
merged 9 commits into from
Nov 13, 2023
Merged

chore: Add Poetry for Python dependency management #278

merged 9 commits into from
Nov 13, 2023

Conversation

eric-nguyen-cs
Copy link
Contributor

What

Adding Poetry for Python dependency management:

  • Now using Poetry for Python dependency management
  • Update the relevant Dockerfile to now use poetry.lock instead of requirements.txt to install dependencies
  • Revamp documentation for local development

Fixes bug(s)

#261

@eric-nguyen-cs eric-nguyen-cs requested a review from a team as a code owner November 4, 2023 23:34
@eric-nguyen-cs eric-nguyen-cs changed the title Adding Poetry for Python dependency management chore: Add Poetry for Python dependency management Nov 4, 2023
alexgarel
alexgarel requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for this query and the work done.

I just have a blocker.

backend/pyproject.toml Outdated Show resolved Hide resolved
docker/dev.yml Outdated Show resolved Hide resolved
taxonomy-editor-frontend/src/constants.js Outdated Show resolved Hide resolved
alexgarel
alexgarel approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I validate so you can merge it, but I think you have one correction to do on a settings.

Great work.

docker/dev.yml Outdated Show resolved Hide resolved
@eric-nguyen-cs eric-nguyen-cs merged commit 2b0c528 into main Nov 13, 2023
7 checks passed
@eric-nguyen-cs eric-nguyen-cs deleted the ericn/add-poetry-to-editor branch November 13, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@eric-nguyen-cs eric-nguyen-cs

Labels
backend dependencies 🐳 Docker docker 📚 documentation Improvements or additions to documentation documentation frontend GitHub parser
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-nguyen-cs @alexgarel