Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taxonomy-editor-frontend): loading animation #283

Merged
merged 7 commits into from
Nov 23, 2023

Conversation

Piv94165
Copy link
Contributor

@Piv94165 Piv94165 commented Nov 9, 2023

What

When waiting for responses from server, a "Loading" text is displayed.
We can add loading animation using mui circular progress component.

Screenshot

reported issue :
#227

Part of

taxonomy-editor-frontend

@Piv94165 Piv94165 changed the title Feature/loading animation feat(taxonomy-editor-frontend): loading animation Nov 9, 2023
@Piv94165 Piv94165 marked this pull request as ready for review November 9, 2023 16:05
@Piv94165 Piv94165 requested a review from a team as a code owner November 9, 2023 16:05
@alexgarel
Copy link
Member

@nobeeakon could you review please ?
Thanks !

@teolemon teolemon linked an issue Nov 16, 2023 that may be closed by this pull request
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works perfectly well, thanks !

@alexgarel alexgarel merged commit 2746f7f into main Nov 23, 2023
7 checks passed
@alexgarel alexgarel deleted the feature/loading-animation branch November 23, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

feat: Use load animation
3 participants