Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add types to find_one_entry routes + start refactor PropertyTable #481

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

eric-nguyen-cs
Copy link
Contributor

What

  • Add return type to find_one_entry route
  • Start refactoring PropertyTable

@teolemon
Copy link
Member

small merge conflict @eric-nguyen-cs

Copy link
Contributor

@perierc perierc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just solve conflicts)

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good !

@eric-nguyen-cs eric-nguyen-cs merged commit cc7df50 into main Apr 17, 2024
7 checks passed
@eric-nguyen-cs eric-nguyen-cs deleted the ericn/fix-property-table-on-safari branch April 17, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants