Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid altering original entries at parsing time #519

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

alexgarel
Copy link
Member

@alexgarel alexgarel commented Jul 17, 2024

We were keeping "lower commas" in text when we parse taxonomies, and also alter parenthesis or commas.

It's problematic when we create the final PR because it induces unwanted changes.

@alexgarel alexgarel requested a review from a team as a code owner July 17, 2024 16:09
@alexgarel alexgarel changed the title fix: restore commas in entries at parsing time fix: avoid altering original entries at parsing time Jul 17, 2024
@alexgarel alexgarel changed the title fix: avoid altering original entries at parsing time fix: avoid altering original entries at parsing time Jul 17, 2024
@alexgarel alexgarel merged commit 5fbaba9 into main Jul 22, 2024
7 checks passed
@alexgarel alexgarel deleted the fix-commas-restore branch July 22, 2024 15:57
alexgarel pushed a commit that referenced this pull request Jul 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.0.2](v1.0.1...v1.0.2)
(2024-07-24)


### Bug Fixes

* add a space after line identifier
([#520](#520))
([51f7b43](51f7b43))
* avoid altering original entries at parsing time
([#519](#519))
([5fbaba9](5fbaba9))
* less transformations on comment lines and others
([#523](#523))
([d366218](d366218))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant