Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3464 - ODP VIEW: do not pass ODP to useIsEditODPEnabled && useShowReviewIndicator #4006

Conversation

minotogna
Copy link
Member

refactor 1

@minotogna minotogna requested a review from sorja October 7, 2024 10:27
@sorja
Copy link
Contributor

sorja commented Oct 7, 2024

print view renders ok?

prop drilling origin:
src/client/pages/Print/OriginalDataPointsPrint/OriginalDataPointsPrint.tsx

@minotogna
Copy link
Member Author

print view renders ok?

prop drilling origin: src/client/pages/Print/OriginalDataPointsPrint/OriginalDataPointsPrint.tsx

yes. what props drilling are you referring to?

@sorja
Copy link
Contributor

sorja commented Oct 7, 2024

print view renders ok?
prop drilling origin: src/client/pages/Print/OriginalDataPointsPrint/OriginalDataPointsPrint.tsx

yes. what props drilling are you referring to?

passing canEditData and originalDataPoint from outside to ODp components, but seems not to be related in this case

👍

      <div className="odp__section-print-mode">
        <h3 className="subhead">{i18n.t('nationalDataPoint.nationalClassifications')}</h3>
        {originalDataPoints.map((originalDataPoint) => (
          <NationalClasses key={originalDataPoint.id} canEditData={false} originalDataPoint={originalDataPoint} />
        ))}
      </div>

@mergify mergify bot merged commit cf3f74f into 3464-odp-view-cycle-2029-dynamic-labelsvariables Oct 7, 2024
5 checks passed
@mergify mergify bot deleted the 3464-odp-view-cycle-2029__auth-refactor branch October 7, 2024 11:33
mergify bot pushed a commit that referenced this pull request Oct 9, 2024
* 3464 - do not pass ODP to useIsEditODPEnabled && useShowReviewIndicator (#4006)

* 3464 - Refactor ODP ButtonBar (#4009)

* 3464 - Refactor ODP ButtonBar

* 3464 - use useOriginalDataPointRouteParams

* 3464 - add SectionNames.extentOfForest

* 3464 - extract nationalDataPoint i18n files (#4010)

* 3464 - refactor useShowReviewIndicator

* 3464 - ODP: custom 2020 logic (#4012)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants