-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly packages fixes, projectGenerator, scripts #8091
Conversation
…bled - http2 is handling this another way automatically. most distros cURL 1.1
Testing the ci simuate Nightly build system script: / testing the nightly... this is generating into a downloadable artifact for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah just need to see final packages but this seems to be all working again
rm -Rf shader | ||
rm -Rf sound | ||
rm -Rf threads | ||
rm -Rf input_output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's tabs right - 2 spaces width, I think the clangformat says otherwise could be causing issues with tab /space style
$ROOT/scripts/dev/create_package.sh msys2 $lastversion master ucrt64 | ||
$ROOT/scripts/dev/create_package.sh vs $lastversion master | ||
$ROOT/scripts/dev/create_package.sh vs $lastversion master 64 | ||
fi | ||
$ROOT/scripts/dev/create_package.sh osx $lastversion master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did this just to make local build work directly as well on macOS
cd $pkg_ofroot | ||
|
||
cd examples | ||
find . -type f -name '*.dll' -delete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont need to deploy dlls from addons all into place in examples for release download, projectGenerator
need to test to make sure addon linked dlls are copied at sln build
@@ -271,6 +271,12 @@ downloader() { | |||
EXTRA_ARGS+="--remove-on-error " | |||
fi | |||
fi | |||
if curl -v | grep -q 'HTTP2'; then | |||
CURL_SUPPORTS_HTTP2=1 | |||
CLOSE_CONNECTION=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http2 does this a different way, so no need to call as response has been generally port kept open and closes with timeout disregarding our header close so no need to send force close port message
Further fixes to nightly packages applied:
Scripts:
scripts/ci/simulate_nightly.sh
Added new developer script to build nightly locally / test on Linux machine or macOS for iOS/macOS targets.
-
scripts/ci/create_package.sh
- removed addon DLLs from example foldersscripts/ci/package_builds.sh
modified to support being run from any platform / not just actionsprojectGenerator 0.70.0 https://github.com/openframeworks/projectGenerator/releases/tag/nightly
downloader [4.2.5 ~ 4.2.6]