Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly packages fixes, projectGenerator, scripts #8091

Merged
merged 17 commits into from
Aug 22, 2024

Conversation

danoli3
Copy link
Member

@danoli3 danoli3 commented Aug 21, 2024

Further fixes to nightly packages applied: 

Scripts:

  • scripts/ci/simulate_nightly.sh
    Added new developer script to build nightly locally / test on Linux machine or macOS for iOS/macOS targets.
    image
    -scripts/ci/create_package.sh - removed addon DLLs from example folders
  • scripts/ci/package_builds.sh modified to support being run from any platform / not just actions

projectGenerator 0.70.0 https://github.com/openframeworks/projectGenerator/releases/tag/nightly

downloader [4.2.5 ~ 4.2.6]

  • verbose log off for closing connection
  • wget2 disabled on windows due to upstream bug on multi files. removed local file if outdated to prevent override issues when detected outdated for cURL / wget2 other platforms

@danoli3
Copy link
Member Author

danoli3 commented Aug 21, 2024

Testing the ci simuate Nightly build system script: / testing the nightly... this is generating into a downloadable artifact for review
https://github.com/openframeworks/openFrameworks/actions/runs/10494016423/job/29069305775?pr=8091

@danoli3 danoli3 requested a review from ofTheo August 21, 2024 16:51
Copy link
Member Author

@danoli3 danoli3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just need to see final packages but this seems to be all working again

rm -Rf shader
rm -Rf sound
rm -Rf threads
rm -Rf input_output
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's tabs right - 2 spaces width, I think the clangformat says otherwise could be causing issues with tab /space style

$ROOT/scripts/dev/create_package.sh msys2 $lastversion master ucrt64
$ROOT/scripts/dev/create_package.sh vs $lastversion master
$ROOT/scripts/dev/create_package.sh vs $lastversion master 64
fi
$ROOT/scripts/dev/create_package.sh osx $lastversion master
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this just to make local build work directly as well on macOS

cd $pkg_ofroot

cd examples
find . -type f -name '*.dll' -delete
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont need to deploy dlls from addons all into place in examples for release download, projectGenerator

need to test to make sure addon linked dlls are copied at sln build

@@ -271,6 +271,12 @@ downloader() {
EXTRA_ARGS+="--remove-on-error "
fi
fi
if curl -v | grep -q 'HTTP2'; then
CURL_SUPPORTS_HTTP2=1
CLOSE_CONNECTION=0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http2 does this a different way, so no need to call as response has been generally port kept open and closes with timeout disregarding our header close so no need to send force close port message

@danoli3 danoli3 merged commit 84aa066 into openframeworks:master Aug 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant