ofParameter: deprecate newReference() in favour of getSharedPtr() #8128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after a good discussion in a workshop on the subtleties of references vs pointers (and shared_ptr) it became evident that the
ofParameter::newReference()
method is ill-named, as it does not return a &reference but a shared_ptr.this deprecates and uses a more correct
getSharedPtr()
name for the same function. it does not seem very widely used — one even wonders why not simply usestd::make_shared()
at the call site...(perhaps the method above used the term "reference" in a more philosophical way, as yes a pointer "refers" to an object, but in C++ "reference" is very specific term that should not be used unless talking about actual &references, even more so in an API)