-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux 2025 #8255
base: master
Are you sure you want to change the base?
Linux 2025 #8255
Conversation
Removed Gold LD for the moment regarding: |
…rather than let continue to code compiltion errors emscripten memory64 renamed 64 as internals are em32 and em64
…sabled for the moment
Actions added 22.04 linux GCC10 test
@ofTheo yeah the library subpath was being used for the targetarch name in for the makefile in the directory! So with linux/64 it was bugging out. I thought it was line spacing tab stuff. Makefiles are so sensitive though wow. It looks like maybe the streamer issue just reported is a spaces instead of tabs issue if they had run the code.
Linking Kiss is missing! Sweet looking into |
ha yeah!!
Spaces vs Tabs was a whole new nightmare - an editor that shows the difference is key there.
|
CompleteUbuntu Ubuntu |
shfmt formatted bash
Rpi disabled while fixed
@@ -80,7 +80,7 @@ linux: | |||
ADDON_LIBS_EXCLUDE = libs/assimp | |||
ADDON_INCLUDES_EXCLUDE = libs/assimp/% | |||
|
|||
linux64: | |||
linux/64: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the old linux64
and linuxarmv6l
still work for PG etc?
@@ -68,21 +68,21 @@ ios: | |||
ADDON_LIBS = libs/svgtiny/lib/ios/svgtiny.a | |||
ADDON_LIBS += libs/libxml2/lib/ios/xml2.a | |||
|
|||
linux64: | |||
ADDON_LIBS = libs/svgtiny/lib/linux64/libsvgtiny.a | |||
ADDON_LIBS += libs/libxml2/lib/linux64/libxml2.a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise will libs still get picked up in older addons from lib/linux64
endif | ||
|
||
# if not defined, construct the default PLATFORM_LIB_SUBPATH | ||
ifndef PLATFORM_LIB_SUBPATH | ||
# determine from the arch | ||
ifeq ($(PLATFORM_OS),Linux) | ||
ifeq ($(PLATFORM_ARCH),x86_64) | ||
PLATFORM_LIB_SUBPATH=linux64 | ||
PLATFORM_LIB_SUBPATH=linux/64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like older projects with addons in lib/linux64/ might not work based on this?
scripts/dev/upgrade.sh added upgrade dev commands to find and replace strings from old versions automatically with sed.
Good idea although make file location is a very minimal issue compared to all the this script will automatically replace issue strings in Called via: In the future this can also add in std:: replacements. Just requires stop and prompt by user since they need to back up files. |
Upgrade script are always handy, but I think we have to be able to support addons that would be fully compliant up until this PR is merged. I know its a pain to support two names, but I'd either suggest leaving the current system of linux64, linuxarmv6l or, making sure both linux/64 and linux64 libs get picked up by make files / PG etc. This feels like the amount it will break, is not worth the conceptual tidiness of having the subfolder approach. Curious what others think, but I am def nervous as it's the osx / macOS issue again, but with even more platforms. |
I think the optional subfolders will complicate the regex needed by makefiles. |
Linux