💥(history) change command history #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We intend to unify the storage and database backend interfaces into a single data backend interface. We also want to separate LRS-specific methods into a dedicated lrs backend interface that extends the data interface.
We add the FileSystem data backend implementation that is mostly taken from the existing FSStorage backend.
Add a common HistoryEntry pydantic model for command history
2 tasks
|
Maybe adding a feature flag on the history would be a great idea? When using a backend as a library there is a high probability that you don't need it! |
wilbrdt
force-pushed
the
unify-data-backends
branch
3 times, most recently
from
dfbe6e8 to
b5c749f
Compare
wilbrdt
force-pushed
the
unify-data-backends
branch
from
b5c749f to
f4d4b9b
Compare
wilbrdt
force-pushed
the
unify-data-backends
branch
from
f429b3a to
addc298
Compare
wilbrdt
force-pushed
the
unify-data-backends
branch
from
718c8f9 to
1babf92
Compare
quitterie-lcs
force-pushed
the
unify-data-backends
branch
2 times, most recently
from
7de2409 to
3cf358c
Compare
wilbrdt
force-pushed
the
unify-data-backends
branch
from
cbfd79c to
25726e7
Compare
wilbrdt
force-pushed
the
unify-data-backends
branch
from
25726e7 to
c94d0f4
Compare
wilbrdt
force-pushed
the
unify-data-backends
branch
from
62dd60e to
2058395
Compare
quitterie-lcs
force-pushed
the
unify-data-backends
branch
from
2058395 to
e6c29ff
Compare
|
Opening issue #474 to add it in the future, closing this as it is too far from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a common HistoryEntry pydantic model for command history.
Proposal
Each backend will be adapted to use HistoryEntry when merged: